feat: Update Dockerfile to add support to arbitrary user ids #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
LGTM except the nits.
Can we add a comment with the doc reference in the docker file?
I think reading this can be useful to understand why.
|
I've made the corrections |
jjaakola-aiven
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This change updates the Dockerfile to handle dynamic User ID (UID) allocation in compliance with OpenShift best practices. It modifies file and directory permissions to ensure compatibility with OpenShift's security requirements, allowing containers to run with arbitrary UIDs while maintaining the required access to essential directories.
References: #983
Why this way
To solve the issue of dynamic UID handling, the proposed approach involves modifying permissions so that the container user can run with a dynamically assigned UID, which OpenShift uses for security purposes. Specifically, we change directory permissions and add the 'karapace' user to group '0', ensuring necessary access without granting root privileges. This adheres to OpenShift's recommendations for secure, multi-tenant container environments, allowing seamless and secure container operation.